Skip to content

CTEditor-z-to-the-r: Add missing module type tags to files starting w… #101051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CTEditor-z-to-the-r: Add missing module type tags to files starting w… #101051

wants to merge 1 commit into from
+234 −220

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Oct 24, 2025 •
edited
Loading

PR adds CONTENT TYPE tags to modules that are missing the tag.

Version(s):
4.12+

Issue:

AsciiDoc Content Type Editor
AsciiDoc Content Type Editor-GH

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 24, 2025 •
edited
Loading

🤖 Tue Oct 28 11:37:35 - Prow CI generated the docs preview:
https://101051--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Oct 24, 2025
View reviewed changes
@dfitzmau dfitzmau force-pushed the CTEditor-z-to-the-r branch from ea8e30f to 8f24d13 Compare October 24, 2025 11:00
dfitzmau
dfitzmau commented Oct 24, 2025
View reviewed changes
dfitzmau
dfitzmau commented Oct 24, 2025
View reviewed changes
@dfitzmau dfitzmau force-pushed the CTEditor-z-to-the-r branch 4 times, most recently from 5edd15b to aec03c6 Compare October 28, 2025 11:25
@dfitzmau dfitzmau force-pushed the CTEditor-z-to-the-r branch from aec03c6 to ba7970e Compare October 28, 2025 11:30
@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 28, 2025
jeana-redhat
jeana-redhat reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, what a pain 😅

Some of these are pretty squishy, especially wrt to formatting that makes their content type unclear/debatable. Some should probably be modularized more fully to truly match the content type. All of that to say: please take these suggestions as suggestions, and if you disagree on any, you're probably as right as any of us until we have more clear standards on some of these types of topics 🤓

/remove-label merge-review-in-progress
/remove-label merge-review-needed

contributing_to_docs/term_glossary.adoc
@@ -1,3 +1,4 @@
:_mod-docs-content-type: ASSEMBLY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should leave this file as-is, it's not really docs

Suggested change
:_mod-docs-content-type: ASSEMBLY

contributing_to_docs/tools_and_setup.adoc
@@ -1,5 +1,7 @@
:_mod-docs-content-type: ASSEMBLY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, should revert this file

Suggested change
:_mod-docs-content-type: ASSEMBLY

snippets/serverless-ha-intro.adoc
@@ -1,4 +1,8 @@
High availability (HA) is a standard feature of Kubernetes APIs that helps to ensure that APIs stay operational if a disruption occurs. In an HA deployment, if an active controller crashes or is deleted, another controller is readily available. This controller takes over processing of the APIs that were being serviced by the controller that is now unavailable.
:_mod-docs-content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:_mod-docs-content-type: CONCEPT
:_mod-docs-content-type: SNIPPET

rest_api/authorization_apis/tokenreview-oauth-openshift-io-v1.adoc
@@ -1,3 +1,5 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray line?

Suggested change

modules/ztp-image-based-upgrade-hub-cluster-guide.adoc
// Module included in the following assemblies:
// * edge_computing/image-based-upgrade/cnf-understanding-image-based-upgrade.adoc

:_mod-docs-content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like ref IMO

modules/sbo-release-notes-1-0-1.adoc
@@ -1,3 +1,4 @@
:_mod-docs-content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:_mod-docs-content-type: CONCEPT
:_mod-docs-content-type: REFERENCE

modules/sbo-release-notes-1-0.adoc
@@ -1,3 +1,4 @@
:_mod-docs-content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:_mod-docs-content-type: CONCEPT
:_mod-docs-content-type: REFERENCE

modules/sdpolicy-platform.adoc
//
// * osd_architecture/osd_policy/osd-service-definition.adoc

:_mod-docs-content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:_mod-docs-content-type: CONCEPT
:_mod-docs-content-type: REFERENCE

modules/security-deploy-image-sources.adoc
//
// * security/container_security/security-deploy.adoc

:_mod-docs-content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:_mod-docs-content-type: CONCEPT
:_mod-docs-content-type: REFERENCE

modules/security-storage-persistent.adoc
//
// * security/container_security/security-storage.adoc

:_mod-docs-content-type: CONCEPT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:_mod-docs-content-type: CONCEPT
:_mod-docs-content-type: REFERENCE

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@jeana-redhat: Those labels are not set on the issue: merge-review-in-progress

In response to this:

Very nice work, what a pain 😅

Some of these are pretty squishy, especially wrt to formatting that makes their content type unclear/debatable. Some should probably be modularized more fully to truly match the content type. All of that to say: please take these suggestions as suggestions, and if you disagree on any, you're probably as right as any of us until we have more clear standards on some of these types of topics 🤓

/remove-label merge-review-in-progress
/remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 28, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

+1 more reviewer

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dfitzmau @ocpdocs-previewbot @openshift-merge-robot @jeana-redhat @ocpdocs-vale-bot